Update docs regarding building dulwich without c bindings #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: jelmer#1093. Currently, both --global-option=--pure and --build-option=--pure work (when set in --config-settings). However, using --global-option in this way is considered deprecated: https://setuptools.pypa.io/en/latest/history.html#id139 pypa/setuptools#3380 --no-binary is needed to prevent pip installing the pre-built wheels from pypi.org.
jelmer
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #1093.
Currently, both
--global-option=--pureand--build-option=--purework (when set in--config-settings). However, using--global-optionin this way is considered deprecated:https://setuptools.pypa.io/en/latest/history.html#id139
pypa/setuptools#3380
--no-binary dulwichis needed to prevent pip installing the pre-built wheel from pypi.org.(Unlike when this was discussed in the issue, setting config-settings in requirements.txt now works.)
Thanks again for the very useful python library (and sorry for bothering you about annoying python packaging), but hopefully this will save somebody time in the future.