Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.13 #1353

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Support Python 3.13 #1353

merged 2 commits into from
Aug 7, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Aug 6, 2024 •
edited
Loading

Closes #1352

@edgarrmondragon edgarrmondragon requested a review from jelmer as a code owner August 6, 2024 22:45
jelmer
jelmer requested changes Aug 6, 2024
View reviewed changes
Copy link
Owner

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to update python-distributions.yml - that's where the actual wheels are built and uploaded

@jelmer jelmer enabled auto-merge August 7, 2024 01:43
@jelmer jelmer self-requested a review August 7, 2024 01:43
@edgarrmondragon
Copy link
Contributor Author

edgarrmondragon commented Aug 7, 2024 •
edited
Loading

I think the error in the 3.13 workflow is python/cpython#122728. The 3.13.0rc2 release will probably be alright.

@jelmer jelmer merged commit a107e66 into jelmer:master Aug 7, 2024
25 of 28 checks passed
@edgarrmondragon edgarrmondragon deleted the py313 branch August 7, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelmer jelmer jelmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3.13
2 participants
@edgarrmondragon @jelmer