Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test symrefs handling for git protocol v2 #1403

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Test symrefs handling for git protocol v2 #1403

merged 2 commits into from
Oct 30, 2024

Conversation

stspdotname
Copy link
Contributor

@stspdotname stspdotname commented Oct 30, 2024 •
edited
Loading

This adds missing compat tests for symref handling in git protocol v2 and fixes a bug in the HTTP client implementation uncovered by the tests.

@stspdotname stspdotname requested a review from jelmer as a code owner October 30, 2024 15:31
@jelmer jelmer enabled auto-merge October 30, 2024 15:32
@jelmer jelmer disabled auto-merge October 30, 2024 15:32
jelmer
jelmer requested changes Oct 30, 2024
View reviewed changes
Copy link
Owner

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes look good, but please take a look at the ruff failures.

@stspdotname
Copy link
Contributor Author

Forgot to run ruff format locally. Fixed now.

@stspdotname stspdotname requested a review from jelmer October 30, 2024 15:51
@jelmer jelmer merged commit d13d454 into jelmer:master Oct 30, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelmer jelmer jelmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stspdotname @jelmer