Drop broken refspecs argument for porcelain.clone #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with other functions where both bytes and strings are accepted. Users can pre-encode if they don't want to use the default encoding, utf-8
This argument never worked properly for the v1 client protocol and is untested. We should re-add it, but until I'd rather not implement it than have it half-working.
jelmer
force-pushed
the
clone-no-refspec
branch
from
60b6c11 to
5fc0b7e
Compare
|
Fine with me for now. I can revisit this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument currently only works for v2 and is untested.
when encoding refspecs, handle the absence case (thanks to @stspdotname in #1416 for finding this)
Also, don't provide separate encoding argument for refspecs. This is consistent with other arguments. Callers that really need a non-standard encoding can do their own encoding and pass in a bytestring.