add easy type hints to some function returns

[castedo]

In the process of stating to use Dulwich (for https://gitlab.com/perm.pub/hidos/-/commits/sshsig), I added the following type hints to get mypy to pass with strict setting (in hidos).

Seems like a very safe merge.

I'll probably have some more type hints in the next few days. I'll ping you when I think I don't have any more type hints to add this week.

[castedo]

@jelmer regarding the failing mypy check ... I can either take out the type hints I added with TreeEntry or I can attempt some further type changes to resolve the type inconsistencies in the code regarding TreeEntry and in_path.

I'm thinking for now I will keep this PR "easy" and take out the TreeEntry type hints and create a separate PR and discussion on these TreeEntry and in_path type inconsistencies. I didn't realize I was starting to open a can of worms. 😅 So I'll try and put the worms in a different PR.

Unless you prefer a bigger less easy wormy PR.

[castedo]

OK, I took on the type hint worms with TreeEntry and ran mypy on ubuntu and it passes now. I'll cycle back to you regarding the TreeEntry.in_path issue.

[castedo]

OK, i looked more into the mypy issue and the 3rd commit is easy and safe enough to go ahead with the extra hint using TreeEntry.

[jelmer]

@jelmer regarding the failing mypy check ... I can either take out the type hints I added with TreeEntry or I can attempt some further type changes to resolve the type inconsistencies in the code regarding TreeEntry and in_path.

I'm thinking for now I will keep this PR "easy" and take out the TreeEntry type hints and create a separate PR and discussion on these TreeEntry and in_path type inconsistencies. I didn't realize I was starting to open a can of worms. 😅 So I'll try and put the worms in a different PR.

Unless you prefer a bigger less easy wormy PR.

That sounds reasonable. In general I prefer smaller but self-contained PRs that can land independently.

[castedo]

Now that 3.9 is the minimum I'm tempted to explore the possibility of converting TreeEntry to a dataclass and enable more type checking. But I should focus first on this sshsiglib work and getting hidos using Dulwich.

[jelmer]

Ptal the ruff failures

[castedo]

Ptal the ruff failures

Oh man, I'm having trouble getting my dev env up to standards here! 😅

I'll eventually get my dev container to be close to these CI checks!

[castedo]

OK, now I've got ruff installed and will use to pre-check.

So do you want me to squash this chain of slightly confused commits?

[jelmer]

Squashing would be preferred, but I can also do that at merge time if the history isn't sensible.

[castedo]

Squashing would be preferred, but I can also do that at merge time if the history isn't sensible.

OK, I gotta run off until after you're probably asleep. I'll squash late tonight if you don't beat me to it.