-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plat 602 keycloak integration #1183
Conversation
…mbi/openhim-core-js into PLAT-602-keycloak-integration
…ub.com/jembi/openhim-core-js into PLAT-602-keycloak-integration
Codecov Report
@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
+ Coverage 86.23% 86.44% +0.21%
==========================================
Files 84 85 +1
Lines 5716 5800 +84
==========================================
+ Hits 4929 5014 +85
+ Misses 787 786 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ub.com/jembi/openhim-core-js into PLAT-602-keycloak-integration
…mbi/openhim-core-js into PLAT-602-keycloak-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. Could you merge the base branch in so I can test it out with the latest changes.
…o PLAT-602-keycloak-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just one small comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In this PR: