Suggesting ControllerToAgentFileCallable (#7678)

jenkins-infra · Nov 12, 2024 · bcb46a7 · bcb46a7
1 parent 787c9c8
commit bcb46a7
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/content/doc/developer/extensibility/serialization-of-anonymous-classes.adoc b/content/doc/developer/extensibility/serialization-of-anonymous-classes.adoc
@@ -34,7 +34,7 @@ To fix code like this:
 int stuff(FilePath workspace, final String arg) throws IOException, InterruptedException {
     return workspace.act(new MasterToSlaveFileCallable<Integer>() {
         @Override
-        Integer invoke(File f, VirtualChannel channel) throws IOException, InterruptedException {
+        public Integer invoke(File f, VirtualChannel channel) throws IOException, InterruptedException {
             return countThings(f, arg);
         }
     });
@@ -43,6 +43,21 @@ int stuff(FilePath workspace, final String arg) throws IOException, InterruptedE
 
 just use a "convert anonymous to member" refactoring in your IDE, or manually:
 
+[source,java]
+----
+private record ThingCounter(String arg) implements ControllerToAgentFileCallable<Integer> {
+    @Override
+    public Integer invoke(File f, VirtualChannel channel) throws IOException, InterruptedException {
+        return countThings(f, arg);
+    }
+}
+int stuff(FilePath workspace, String arg) throws IOException, InterruptedException {
+    return workspace.act(new ThingCounter(arg));
+}
+----
+
+or prior to Jenkins 2.485:
+
 [source,java]
 ----
 private static final class ThingCounter extends MasterToSlaveFileCallable<Integer> {
@@ -51,7 +66,7 @@ private static final class ThingCounter extends MasterToSlaveFileCallable<Intege
         this.arg = arg;
     }
     @Override
-    Integer invoke(File f, VirtualChannel channel) throws IOException, InterruptedException {
+    public Integer invoke(File f, VirtualChannel channel) throws IOException, InterruptedException {
         return countThings(f, arg);
     }
 }