Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cluster nodes rsg client ID to jx-requirements #183

Merged
merged 2 commits into from
Jul 12, 2023
Merged

feat: add cluster nodes rsg client ID to jx-requirements #183

merged 2 commits into from
Jul 12, 2023

Conversation

Skisocks
Copy link
Contributor

@Skisocks Skisocks commented May 10, 2023 •
edited
Loading

Adds the Client ID for the cluster nodes resource group to jx-requirements. This is needed for identifying which service principal to use when pushing containers to the registry (in the case where there are multiple principals).

jenkins-x/jx#8580

@jenkins-x-bot
Copy link
Contributor

Hi @Skisocks. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@Skisocks
Copy link
Contributor Author

/assign @msvticket

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Skisocks Skisocks mentioned this pull request May 10, 2023
Merged
@Skisocks
Copy link
Contributor Author

/cc @msvticket

@msvticket
Copy link
Member

Same here, Tom is the man.

/cc tomhobson

@Skisocks
Copy link
Contributor Author

Skisocks commented Jul 7, 2023

/cc @tomhobson 😄

@tomhobson
Copy link
Member

/ok-to-test

@tomhobson
Copy link
Member

/approve

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 8a4de2f into jenkins-x:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhobson tomhobson tomhobson approved these changes

@msvticket msvticket Awaiting requested review from msvticket

Assignees

@msvticket msvticket

Labels
approved ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Skisocks @jenkins-x-bot @msvticket @tomhobson