Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Selenium 4 based docker containers in FallbackConfig #1077

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Mar 22, 2023

The containers should match the selenium version. using old version 3 containers is not a good idea :)

this got missed in #973
@uhafner I think you are the only user of the container support.

based on #1043 and #1045 this probably needs some testing in the consumer.

https://hub.docker.com/r/selenium/standalone-firefox/tags?page=1&name=4.6.0
https://hub.docker.com/r/selenium/standalone-chrome/tags?page=1&name=4.6.0

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The containers should match the selenium version.  using old version 3 containers is not a good idea :)
@jtnord jtnord requested review from uhafner and timja March 22, 2023 10:33
@jtnord
Copy link
Member Author

jtnord commented Mar 22, 2023

core.InstallWizardTest.wizardInstallCustomPluginsTest failed is so flaky of late :(

Also noting a conflict with #1073

@NotMyFault NotMyFault added the bug label Mar 23, 2023
@uhafner
Copy link
Member

uhafner commented Mar 23, 2023

Are we creating incremental ATH versions? Then I can use the snapshot in my Selenium upgrade PR. Seems that Jenkins still is building this PR...

@uhafner uhafner changed the title Update FallbackConfig.java Use Selenium 4 based docker containers in FallbackConfig Mar 23, 2023
@jtnord
Copy link
Member Author

jtnord commented Mar 23, 2023

Are we creating incremental ATH versions? Then I can use the snapshot in my Selenium upgrade PR. Seems that Jenkins still is building this PR...

I don't think we do.
in the interim you can try version 999999-20230323.135212-4 which I just deployed from this code.

uhafner added a commit to jenkinsci/warnings-ng-plugin that referenced this pull request Mar 28, 2023
@rsandell rsandell enabled auto-merge (squash) March 30, 2023 11:24
@rsandell rsandell merged commit d392288 into master Mar 30, 2023
@rsandell rsandell deleted the update-selenium-container branch March 30, 2023 12:31
@uhafner
Copy link
Member

uhafner commented Apr 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants