Jenkins 33833: get history to work again in batch tasks #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The batch task history has been broken for a while. See https://issues.jenkins.io/browse/JENKINS-33833 for discussion and analysis.
This is a quick&dirty test to get this working again.
The PR currently sits on top of #11 which I hope to merge soon.
I would like some feedback on the approach and the direction of the feature from people with more knowledge of the internals and direction of Jenkins.
Implementation notes
Given that the HistoryPageFilter#add() logic, there were at least 3 options:
I implemented a very rough "like a Job" solution and it starts giving some result, although plenty is still broken and it doesn't have any code to manage migration for now.
One issue that I am definitely seeing right away is that in my current implementation, the BatchRun became a Run subclass, and I am not able to serialize it nested in the build log anymore.
I've attempted a different design (different branch), where I pass adapter classes to the build history widget, but the Run class doesn't allow to set its state at Runtime.
More info in the issue.
Testing done
Submitter checklist