[JENKINS-35411] Migrate batch-task-plugin to 2.x parent pom #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,13 +34,22 @@ | |||
| <build> | |||
| <plugins> | |||
| <plugin> | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <groupId>org.codehaus.mojo</groupId> | |||
| <artifactId>findbugs-maven-plugin</artifactId> | |||
There was a problem hiding this comment.
This, I think, can be removed since it is defined in the parent POM
|
🐝 |
| freeStyleProject.addProperty(new BatchTaskProperty(task)); | ||
| HtmlPage page = r.createWebClient().getPage(freeStyleProject, "batchTasks/task/test/execute"); | ||
| String path = page.getWebResponse().getWebRequest().getUrl().getPath(); | ||
| assertTrue("should redirect to noBuilds page: " + path, path.endsWith("/noBuild")); |
There was a problem hiding this comment.
Does this test do the same as the one originally written in Groovy? Specially the first part up until the first assertTrue
|
LGTM. Just one question pending and one comment to address. |
|
🐝 although would be good to not ignore findbugs at some point "Windbags", damned spell checker! It has happened to me as well :) |
|
@reviewbybees done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reviewbybees CC @andresrc @armfergom