Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build-failure-analyzer-plugin#181 workaround #3537

Open
basil opened this issue Sep 4, 2024 · 3 comments · Fixed by #3840
Open

Remove build-failure-analyzer-plugin#181 workaround #3537

basil opened this issue Sep 4, 2024 · 3 comments · Fixed by #3840
Labels

Comments

@basil
Copy link
Member

basil commented Sep 4, 2024

Once jenkinsci/build-failure-analyzer-plugin#181 is merged, released, and adopted, the workaround added in #3508 should be deleted.

@basil basil added the tests label Sep 4, 2024
darinpope added a commit to darinpope/bom that referenced this issue Oct 25, 2024
Now that PR-3838 has merged, reverting the excludes for BFA.
@basil basil mentioned this issue Oct 25, 2024
6 tasks
darinpope added a commit to darinpope/bom that referenced this issue Oct 25, 2024
it appears the fix doesn't cover jenkinsci#3537. Putting this back in to see if jenkinsci#3539 works ok.
MarkEWaite pushed a commit that referenced this issue Oct 25, 2024
Now that PR-3838 has merged, reverting the excludes for BFA.
@darinpope
Copy link
Contributor

We can't close this one yet. It's still broken.

I should have done the 2 issues separately.

@darinpope darinpope reopened this Oct 25, 2024
@darinpope
Copy link
Contributor

darinpope commented Oct 29, 2024

We need to wait for 2.452.x and 2.462.x to both fall off before we can remove the excludes for 181.

The first LTS release date (if I did calendar math right) where that happens is June 25, 2025. That means the 2.479.x line will be the oldest line about 4 weeks before, or somewhere around May 28, 2025.

@basil
Copy link
Member Author

basil commented Oct 29, 2024

The test fix from jenkinsci/build-failure-analyzer-plugin#181 could also be backported to the older lines, but casual maintainers are unlikely to do this and it's likely not worth the effort for a fix that doesn't affect production users. Just mentioning this for completeness, as I have done it before for plugins I maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants