Add Artifact Manager S3 to the managed set

[darinpope]

Add Artifact Manager S3 to the managed set

Testing done

• LINE=2.452.x PLUGINS=artifact-manager-s3 bash local-test.sh
• LINE=2.462.x PLUGINS=artifact-manager-s3 bash local-test.sh
• LINE=2.479.x PLUGINS=artifact-manager-s3 bash local-test.sh
• LINE=weekly PLUGINS=artifact-manager-s3 bash local-test.sh

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[basil]

Thanks! Please just make sure full-test is passing after you land all of these.

[jglick]

Beware that #286 (comment) still applies: the coverage you gain by this is minimal.

[basil]

Agreed that the coverage gains for plugins whose tests use Docker is minimal, but perhaps one day we will run BOM tests in an environment where Docker is available (just as they are within CloudBees). Even if the coverage gains are minimal, running as many test suites as possible in a single job is useful in order to do things like scope out Java upgrades (for example, to discover which plugins use test libraries that won't work on recent Java runtimes).

[jglick]

Yes. To be clear,

plugins whose tests use Docker

is only partly the case here: most of the interesting tests require AWS credentials; the ones which can run without AWS credentials but require Docker cover some basic “smoke test” scenarios—enough to detect critical regressions in PCT in most dependencies, but perhaps not for example the AWS SDK.