Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe 2 known issues and link to example pull requests #3980

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Describe 2 known issues and link to example pull requests #3980

merged 1 commit into from
Nov 18, 2024

Conversation

MarkEWaite
Copy link
Contributor

Describe 2 known issues and link to example pull requests

Issue 3158 provides the fundamental information for the pull request.

HPI plugin PR 391 provides additional commentary.

Also removes trailing spaces from lines in the file.

Testing done

Checked that page renders correctly after the changes.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Describe 2 known issues and link to example pull requests
01ff4ec 
jenkinsci#3158 provides the fundamental
information for the pull request.

jenkinsci/maven-hpi-plugin#391 provides additional
commentary.

Also removes trailing spaces from lines in the file.
@MarkEWaite MarkEWaite requested a review from a team as a code owner November 16, 2024 17:35
krisstern
krisstern approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkEWaite MarkEWaite mentioned this pull request Nov 16, 2024
Merged
6 tasks
basil
basil approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 79a84ad into jenkinsci:master Nov 18, 2024
5 checks passed
@MarkEWaite MarkEWaite deleted the document-optional-dependency-failure-mode branch November 18, 2024 20:08
@MarkEWaite MarkEWaite added the documentation Improvements or additions to documentation label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisstern krisstern krisstern approved these changes

@basil basil basil approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkEWaite @basil @krisstern