Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Coverage to the managed set #3986

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Add Coverage to the managed set #3986

merged 1 commit into from
Nov 19, 2024

Conversation

darinpope
Copy link
Contributor

@darinpope darinpope commented Nov 18, 2024 •
edited
Loading

Add Coverage to the managed set

Testing done

  • LINE=weekly PLUGINS=coverage bash local-test.sh
  • LINE=2.479.x PLUGINS=coverage bash local-test.sh
  • LINE=2.462.x PLUGINS=coverage bash local-test.sh
  • LINE=2.452.x PLUGINS=coverage bash local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@darinpope darinpope added the full-test Test all LTS lines in this PR and do not halt upon first error. label Nov 18, 2024
@darinpope darinpope marked this pull request as ready for review November 18, 2024 21:33
@darinpope darinpope requested a review from a team as a code owner November 18, 2024 21:33
@darinpope
Copy link
Contributor Author

darinpope commented Nov 18, 2024 •
edited
Loading

so first run of https://ci.jenkins.io/job/Tools/job/bom/view/change-requests/job/PR-3986/ had an artifact failure that passed in the 2nd run. The second run had a failure in a different artifact failure that passed in the first run.

Any opposition in force merging because of those 2 different failures?

@darinpope darinpope merged commit 998cfff into jenkinsci:master Nov 19, 2024
833 of 836 checks passed
@darinpope darinpope deleted the add-coverage branch November 19, 2024 15:06
@MarkEWaite MarkEWaite added the enhancement New feature or request label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darinpope @MarkEWaite