Automate updating weekly version #689

timja · 2021-10-21T07:13:04Z

Automate updating weekly version
Downgrade weekly for testing on CI

updatecli/updatecli.d/weekly-apply.sh

jglick · 2021-10-21T15:26:55Z

.github/workflows/updatecli.yaml

+      - uses: tibdex/github-app-token@v1
+        id: generate-token
+        with:
+          app_id: ${{ secrets.JENKINS_DEPENDENCY_UPDATER_APP_ID }}
+          private_key: ${{ secrets.JENKINS_DEPENDENCY_UPDATER_PRIVATE_KEY }}


Is there a reason we cannot use the standard $GITHUB_TOKEN?

We had an issue with it in the helm-charts repo, something to do with other workflows not starting correctly, we had to always push a new commit or re-run all jobs. May be ok in a repo not using github actions.

There was another issue IIRC about it committing as the last user to commit to the main branch but that's probably fixed by specifying the bot details

As per https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow:

When you use the repository's GITHUB_TOKEN to perform tasks on behalf of the GitHub Actions app, events triggered by the GITHUB_TOKEN will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

We had to create a technical user on https://github.com/updatecli/ to avoid this problem (PR opened but no workflow triggered).

events triggered by the GITHUB_TOKEN will not create a new workflow run

Fine…why would we care here? Our only push-triggered action is a Jenkins build.

I join @jglick if we can rely on a GITHUB_TOKEN, I think it's better as we don't have to rotate that password.

the credentials are managed centrally here, so doesn't really make much difference but yeah sure will switch when I get a chance later on

jglick · 2021-10-21T15:31:45Z

sample-plugin/pom.xml

@@ -14,7 +14,7 @@
    <properties>
        <changelist>999999-SNAPSHOT</changelist>
        <bom>weekly</bom>
-        <jenkins.version>2.317</jenkins.version>
+        <jenkins.version>2.316</jenkins.version>


Why? Just to see if the workflow will bump it back up again?

updatecli/updatecli.d/weekly-apply.sh

.github/workflows/updatecli.yaml

jglick · 2021-10-21T15:38:59Z

.github/workflows/updatecli.yaml

+          flags: "--config ./updatecli/updatecli.d --values updatecli/values.yaml"
+        env:
+          UPDATECLI_GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}
+
+      - name: Apply
+        uses: updatecli/updatecli-action@v1
+        with:
+          flags: "--config ./updatecli/updatecli.d --values updatecli/values.yaml"


Suggested change

flags: "--config ./updatecli/updatecli.d --values updatecli/values.yaml"

env:

UPDATECLI_GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}

- name: Apply

uses: updatecli/updatecli-action@v1

with:

flags: "--config ./updatecli/updatecli.d --values updatecli/values.yaml"

flags: "--config updatecli/updatecli.d --values updatecli/values.yaml"

env:

UPDATECLI_GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}

- name: Apply

uses: updatecli/updatecli-action@v1

with:

flags: "--config updatecli/updatecli.d --values updatecli/values.yaml"

?

I vote for starting with ./: it helps when reading (or getting started) to undertsand that it's a file path relative to the working dir

Is there any other reason than just eye habit? I am more used to './' than nothing.

Co-authored-by: Jesse Glick <[email protected]>

dduportal

2 feedbacks :) But good idea and thanks for doing it!

dduportal · 2021-10-21T16:27:53Z

.github/workflows/updatecli.yaml

+      - name: Diff
+        uses: updatecli/updatecli-action@v1
+        with:
+          command: diff


@timja is there a reason to perform a diff in this workflow? I understand that the "apply" is always performed so it seems redundant?

On other github.com/jenkins-infra/jenkins-infra repositories:

The "apply" is only executed on the principal branch (ref. https://github.com/jenkins-infra/jenkins-infra/blob/production/.github/workflows/updatecli.yaml#L34) because we know it's built once a day, week, hour

While the diff is always executed to ensure that a PR does not break updatecli

I just copied this out of the github workflow guide on updatecli.io

https://www.updatecli.io/docs/automate/github_action/

updatecli/updatecli.d/weekly-apply.sh

olblak

Once the other feedbacks have been implemented, this PR seems to good to me

timja · 2021-10-21T20:46:30Z

It's not working because maven and java aren't in the update cli docker image.
I'll take a look tomorrow probably switching to sed commands I guess

unless anyone has any better ideas

dduportal · 2021-10-21T21:33:54Z

You can install maven and java as part of the script, OR use a maven docker image and add updatecli binary instead ?

…

Le 21 oct. 2021 à 22:46, Tim Jacomb ***@***.***> a écrit : It's not working because maven and java aren't in the update cli docker image. I'll take a look tomorrow probably switching to sed commands I guess unless anyone has any better ideas — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

timja added 2 commits October 21, 2021 08:12

Automate updating weekly version

9946bf9

Downgrade weekly for testing on CI

550c43f

timja added the chore Reduces future maintenance label Oct 21, 2021

timja requested review from dduportal, olblak and jglick October 21, 2021 07:13

timja commented Oct 21, 2021

View reviewed changes

updatecli/updatecli.d/weekly-apply.sh Outdated Show resolved Hide resolved

Update updatecli/updatecli.d/weekly-apply.sh

3adc568

jglick reviewed Oct 21, 2021

View reviewed changes

Update .github/workflows/updatecli.yaml

8282cbb

Co-authored-by: Jesse Glick <[email protected]>

dduportal requested changes Oct 21, 2021

View reviewed changes

olblak approved these changes Oct 21, 2021

View reviewed changes

Review feedback

7bd8bdf

timja requested review from jglick and jetersen October 21, 2021 20:18

jetersen approved these changes Oct 21, 2021

View reviewed changes

timja merged commit f5ebb50 into jenkinsci:master Oct 21, 2021

timja deleted the automate-updating-weekly-version branch October 21, 2021 20:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automate updating weekly version #689

Automate updating weekly version #689

timja commented Oct 21, 2021

jglick Oct 21, 2021

timja Oct 21, 2021

dduportal Oct 21, 2021

jglick Oct 21, 2021

olblak Oct 21, 2021

timja Oct 21, 2021

jglick Oct 21, 2021

timja Oct 21, 2021

jglick Oct 21, 2021

dduportal Oct 21, 2021

olblak Oct 21, 2021 •

edited

Loading

dduportal left a comment

dduportal Oct 21, 2021

timja Oct 21, 2021

timja Oct 21, 2021

olblak left a comment •

edited

Loading

timja commented Oct 21, 2021 •

edited

Loading

dduportal commented Oct 21, 2021 via email

Automate updating weekly version #689

Automate updating weekly version #689

Conversation

timja commented Oct 21, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olblak Oct 21, 2021 • edited Loading

Choose a reason for hiding this comment

dduportal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olblak left a comment • edited Loading

Choose a reason for hiding this comment

timja commented Oct 21, 2021 • edited Loading

dduportal commented Oct 21, 2021 via email

olblak Oct 21, 2021 •

edited

Loading

olblak left a comment •

edited

Loading

timja commented Oct 21, 2021 •

edited

Loading