Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not flood the logs with branch-api causes #36

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Do not flood the logs with branch-api causes #36

merged 1 commit into from
Aug 1, 2022

Conversation

StefanSpieker
Copy link
Contributor

Since we are using the branch-api plugin together with GitHub our log is flooded with lines like this:

Unsupported cause type(s): [jenkins.branch.BranchEventCause@5ca9b86c]
Feb 03, 2022 9:35:13 AM WARNING org.jenkinsci.plugins.builduser.BuildUser handleOtherCausesOrLogWarningIfUnhandled

Since this cause is never triggerd by a user, I just want to ignore it.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@StefanSpieker StefanSpieker marked this pull request as ready for review February 5, 2022 09:42
@StefanSpieker
Copy link
Contributor Author

We tested this on our instance and it works. Any feedback from your side would be appreciated.

@StefanSpieker
Copy link
Contributor Author

@fabiodcasilva: Any chance this gets merged? We have this running within our instance for a couple of months now.

martinda
martinda suggested changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@martinda martinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave this with "request changes" until I find out the answer.

pom.xml
<artifactId>branch-api</artifactId>
<version>2.6.0</version>
<optional>true</optional>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this force my jenkins instance to install the branch-api plugin when I don't need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is marked as optional as stated here: https://www.jenkins.io/doc/developer/plugin-development/optional-dependencies/

So you do not need this dependency

martinda
martinda approved these changes Jun 18, 2022
View reviewed changes
Copy link
Contributor

@martinda martinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fabiodcasilva fabiodcasilva merged commit adfb423 into jenkinsci:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiodcasilva fabiodcasilva fabiodcasilva approved these changes

@martinda martinda martinda approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanSpieker @martinda @fabiodcasilva