Bump artifactory from 3.4.0 to 3.11.2

[basil]

Fixes #1607 and JENKINS-65687. Supersedes #1608 and #1609.
closes #1608, closes #1609

This PR isn't fully working yet; MailExtTest.shouldProperlyRoundTripTokenMacro fails with

io.jenkins.plugins.casc.ConfiguratorException: unclassified: error configuring 'unclassified' with class io.jenkins.plugins.casc.impl.configurators.GlobalConfigurationCategoryConfigurator configurator
        at io.jenkins.plugins.casc.ConfigurationAsCode.invokeWith(ConfigurationAsCode.java:719)
        at io.jenkins.plugins.casc.ConfigurationAsCode.checkWith(ConfigurationAsCode.java:777)
        at io.jenkins.plugins.casc.ConfigurationAsCode.configureWith(ConfigurationAsCode.java:762)
        at io.jenkins.plugins.casc.ConfigurationAsCode.configureWith(ConfigurationAsCode.java:638)
        at io.jenkins.plugins.casc.ConfigurationAsCode.configureWith(ConfigurationAsCode.java:632)
        at io.jenkins.plugins.casc.MailExtTest.shouldProperlyRoundTripTokenMacro(MailExtTest.java:71)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:601)
        at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
        at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.lang.Thread.run(Thread.java:748)
Caused by: io.jenkins.plugins.casc.ConfiguratorException: Cannot find configurator for type class org.jfrog.hudson.ArtifactoryServer
        at io.jenkins.plugins.casc.impl.DefaultConfiguratorRegistry.lookupOrFail(DefaultConfiguratorRegistry.java:69)
        at io.jenkins.plugins.casc.ConfigurationContext.lookupOrFail(ConfigurationContext.java:112)
        at io.jenkins.plugins.casc.BaseConfigurator.configure(BaseConfigurator.java:337)
        at io.jenkins.plugins.casc.BaseConfigurator.check(BaseConfigurator.java:287)
        at io.jenkins.plugins.casc.BaseConfigurator.configure(BaseConfigurator.java:351)
        at io.jenkins.plugins.casc.BaseConfigurator.check(BaseConfigurator.java:287)
        at io.jenkins.plugins.casc.ConfigurationAsCode.lambda$checkWith$8(ConfigurationAsCode.java:777)
        at io.jenkins.plugins.casc.ConfigurationAsCode.invokeWith(ConfigurationAsCode.java:713)
        ... 18 more

I started looking into this and found that the exported config contained

unclassified:
  artifactoryBuilder:
    artifactoryServers: |-
      FAILED TO EXPORT
      org.jfrog.hudson.ArtifactoryBuilder$DescriptorImpl#artifactoryServers: No configurator found for type class org.jfrog.hudson.ArtifactoryServer
    jfrogPipelinesServer:
      bypassProxy: false
      connectionRetries: 3
      credentialsConfig:
        overridingCredentials: false
        username: "****"
      timeout: 300
    useCredentialsPlugin: false

which was then causing the test to trip up later. Not sure if this can be worked around temporarily or if this will need to be addressed in the Artifactory plugin itself.

[timja]

@eyalbe4 looks like the configuration as code integration is broken in your last release, I recommend you add an automated test to your plugin

https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/docs/PLUGINS.md#how-to-test

[basil]

This PR is now downstream of jfrog/jenkins-artifactory-plugin#492, which fixes the regression introduced in jfrog/jenkins-artifactory-plugin#455.

[basil]

The PR build failed to download my timestamped snapshot from https://repo.jenkins-ci.org/snapshots/ but it worked fine for me locally.

[codecov]

Codecov Report

Merging #1610 (dd2f7ab) into master (a19ce9f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1610   +/-   ##
=========================================
  Coverage     80.51%   80.51%           
  Complexity      817      817           
=========================================
  Files            66       66           
  Lines          2402     2402           
  Branches        340      340           
=========================================
  Hits           1934     1934           
  Misses          359      359           
  Partials        109      109           

[basil]

3.11.2 (released 2 days ago) seems to work. I think this PR is ready to merge now.