No need to bundle jsch.jar #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc1arke
approved these changes
Feb 28, 2018
recena
approved these changes
Feb 28, 2018
oleg-nenashev
requested changes
Feb 28, 2018
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>jsch</artifactId> | ||
| <version>0.1.54.2</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.lib</groupId> | ||
| <artifactId>cvsclient</artifactId> |
There was a problem hiding this comment.
Would it it make sense to explicitly add an exclusion here? Otherwise we may still have an issue with bundling of the library dependencies after the patch
There was a problem hiding this comment.
Should not be necessary:
requireUpperBoundsDepsalready enforces that the desired version is selected. (For example, if you swap the order of the two explicit deps, the build fails.)- I manually verified that
cvs.hpicontainedjsch.jarbefore but not after this patch.
There was a problem hiding this comment.
Will it also exclude transient deps in such case. E.g. if the previous jsch library includes foo.bar which is no longer bundled in 0.1.54
There was a problem hiding this comment.
It should, but anyway there are no such dependencies.
There was a problem hiding this comment.
Specifically mvn:dependency-tree:
--- before 2018-02-28 15:46:22.539439704 -0500
+++ after 2018-02-28 15:46:31.043479035 -0500
@@ -1,6 +1,11 @@
[INFO] org.jenkins-ci.plugins:cvs:hpi:2.14-SNAPSHOT
+[INFO] +- org.jenkins-ci.plugins:jsch:jar:0.1.54.2:compile
+[INFO] | +- com.jcraft:jsch:jar:0.1.54:compile
+[INFO] | \- org.jenkins-ci.plugins:ssh-credentials:jar:1.13:compile
+[INFO] | \- org.jenkins-ci.plugins:credentials:jar:2.1.0:compile
+[INFO] | \- org.antlr:antlr4-runtime:jar:4.5:compile
+[INFO] | \- org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1:compile
[INFO] +- org.jenkins-ci.lib:cvsclient:jar:71-jenkins-11:compile
-[INFO] | \- com.jcraft:jsch:jar:0.1.50:compile
[INFO] +- org.reflections:reflections:jar:0.9.9:test
[INFO] | +- com.google.guava:guava:jar:15.0:provided
[INFO] | \- org.javassist:javassist:jar:3.18.2-GA:test
oleg-nenashev
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor follow-up to #46. jenkinsci/cvsclient#3 (which I am not proposing to integrate) passes with the dependency bump.
@reviewbybees