-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins workflow support #7
Conversation
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
useUnstable ? regexpForFailed : regexp, | ||
useUnstable ? descriptionForFailed : description); | ||
} | ||
|
||
@Override | ||
public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This overload can simply be deleted.
Note that as of 1.4 you can just write currentBuild.description = 'whatever' There may still be value in integrating this plugin if it does some special computation of the description that would be awkward to replicate in your script. |
Oh, I didn't know about |
Not sure. I only know from glancing at its source code what all it does. Seems it has some facility to set a description according to parsing of the log text. Potentially useful, though I think this might be better done by giving you access to the log in |
For my use-case |
IIRC the documentation for |
But yeah, other mentions would be appropriate. |
Added support for Jenkins Workflow, according to this manual:
https://github.com/jenkinsci/workflow-plugin/blob/master/basic-steps/CORE-STEPS.md#adding-support-from-plugins
Not sure what to do with the matrix project dependency. How are dependencies on other plugins handled in Jenkins plugins in general? Is this okay?