Configuration as Code support #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests and Symbols
rsandell
requested review from
jtnord,
alecharp,
oleg-nenashev,
varyvol and
MRamonLeon
varyvol
reviewed
Jun 30, 2020
| @@ -114,7 +115,8 @@ public DockerTool forNode(Node node, TaskListener log) throws IOException, Inter | |||
| } | |||
| } | |||
|
|
|||
| @Extension public static class DescriptorImpl extends ToolDescriptor<DockerTool> { | |||
| @Extension @Symbol("dockerTool") | |||
There was a problem hiding this comment.
It was already the symbol used, so I'm not sure adding it is confusing?
There was a problem hiding this comment.
Just in case the algorithm for the default name changes in the future
There was a problem hiding this comment.
alecharp
reviewed
Jun 30, 2020
| <workflow-cps.version>2.67</workflow-cps.version> | ||
| <workflow-support.version>3.3</workflow-support.version> | ||
| <pipeline-model-definition-version>1.3.8</pipeline-model-definition-version> | ||
| <jcasc.version>1.41</jcasc.version> |
There was a problem hiding this comment.
as you are using the plugin BOM (which is great!), the JCasC version is normally defined in it. Is it not?
There was a problem hiding this comment.
Not sure, a bunch of stuff isn't
There was a problem hiding this comment.
it seems that you can. but it's not a blocker for me
src/test/resources/org/jenkinsci/plugins/docker/commons/casc_bare.yaml
Outdated
Show resolved
Hide resolved
…are.yaml new line at end of file Co-authored-by: Adrien Lecharpentier <[email protected]>
varyvol
approved these changes
Jun 30, 2020
MRamonLeon
approved these changes
Jun 30, 2020
alecharp
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to verify it works.
Added Symbols to make the configuration more neat looking and readable.
Updated pom to use the current JCasC version.