Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions regarding GitHub Branch Source Plugin notifications #373

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

ViliusS
Copy link
Contributor

@ViliusS ViliusS commented Jan 21, 2024

It looks like newest versions of GitHub Checks plugin already implements a trait to turn off duplicate notifications coming from GitHub Branch Source Plugin.

This PR just updates README instructions to use the new option instead of other plugins.

Testing done

I don't have Disable GitHub Multibranch Status Plugin or Skip Notification Trait Plugin installed. I just configured multibranch pipeline to disable status updates from GitHub Branch Source Plugin in the pipeline settings:
image
This produced only one commit status update in the GitHub UI:
image

Submitter checklist

Preview Give feedback

@ViliusS ViliusS requested a review from a team as a code owner January 21, 2024 17:42
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c724318) 71.80% compared to head (94226c5) 71.80%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #373   +/-   ##
=========================================
  Coverage     71.80%   71.80%           
  Complexity      162      162           
=========================================
  Files            16       16           
  Lines           532      532           
  Branches         51       51           
=========================================
  Hits            382      382           
  Misses          124      124           
  Partials         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@timja timja added the documentation Improvements or additions to documentation label Jan 21, 2024
@timja timja merged commit fa2c600 into jenkinsci:master Jan 21, 2024
17 checks passed
@timja
Copy link
Member

timja commented Jan 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants