Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73907] Fix double-escaped tooltips in "Help for feature" #10000

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ridemountainpig
Copy link
Contributor

See JENKINS-73907.

Testing done

CleanShot 2024-11-21 at 11 14 20

Proposed changelog entries

  • Fix double-escaped tooltips in "Help for feature"

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@daniel-beck daniel-beck added the needs-security-review Awaiting review by a security team member label Nov 21, 2024
@daniel-beck
Copy link
Member

#10000 🎉

@daniel-beck daniel-beck added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Nov 22, 2024
@daniel-beck
Copy link
Member

I confirmed the expected outcome manually in Security2779Test.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after the next weekly release if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases security-approved @jenkinsci/core-security-review reviewed this PR for security issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants