Create a tmp directory when such doesn't exist. In some cases the tmp… #10002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… director won't exist and an Exception will be thrown when attempting to create a file in that directory. An example of such case is creating a JenkinsRule instance in some tests and executing those tests from an IDE.
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
zbynek
reviewed
Nov 23, 2024
core/src/main/java/hudson/Util.java
Outdated
| if (!systemTmpDirectoryPath.toFile().exists()){ | ||
| // In some cases the tmp directory set in the java.io.tmpdir property will not exist and hence will have to | ||
| // be created here. | ||
| systemTmpDirectoryPath.toFile().mkdirs(); |
There was a problem hiding this comment.
Using Files.createDirectory instead should avoid the SpotBugs warning.
zbynek
reviewed
Nov 23, 2024
core/src/main/java/hudson/Util.java
Outdated
| @@ -436,6 +436,14 @@ public static File createTempDir() throws IOException { | |||
| // https://github.com/jenkinsci/jenkins/pull/3161 ) | |||
| final Path tempPath; | |||
| final String tempDirNamePrefix = "jenkins"; | |||
|
|
|||
| final Path systemTmpDirectoryPath = Path.of(System.getProperty("java.io.tmpdir")); | |||
| if (!systemTmpDirectoryPath.toFile().exists()){ | |||
There was a problem hiding this comment.
Suggested change
| if (!systemTmpDirectoryPath.toFile().exists()){ | |
| if (!systemTmpDirectoryPath.toFile().exists()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While writing Jenkins plugin tests and debugging them in IntelliJ I stumbled upon an issue when trying to create an instance of JenkinsRule, which was failing to instantiate due to the following exception:
I was debugging the test from within IntelliJ and what I noticed was that IntelliJ was setting the
java.io.tmpdirproperty to be atmpdirectory within the project target directory, which doesn't exist my default, hence why I am creating this PR. This issue could have been resolved with extra maven hackery in my plugin's pom.xml, but I thought that this issue might occur in different scenarios as well and why not handle it here.