Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the timestamp on the footer more compact #4651

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

fqueiruga
Copy link
Contributor

Small improvement to the footer timestamp. The font size is reduced to 12px and the label is shown on top of the timestamp:

Captura de pantalla 2020-04-13 a las 16 40 15

Proposed changelog entries

N/A I'd say. The footer changes haven't been released on an LTS yet, and this is a really small one.

Proposed upgrade guidelines

N/A

Submitter checklist

  • JIRA issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@Wadeck
@oleg-nenashev
@timja
@daniel-beck

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a JIRA issue should exist and be labeled as lts-candidate

@oleg-nenashev oleg-nenashev added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Apr 13, 2020
@oleg-nenashev
Copy link
Member

Does the footer height remain the same after the change?

@fqueiruga
Copy link
Contributor Author

It does, still 56px

Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine :) not tested manually.

@daniel-beck
Copy link
Member

WDYT of making

<span class="page-footer__generated-timestamp"><i:formatDate value="${h.getCurrentTime()}" type="both" dateStyle="medium" timeStyle="long"/></span>
a bit nicer as well:

dateStyle="short" would have dates like this (shown based on 2.231):

Screenshot 2020-04-14 at 23 14 43

Screenshot 2020-04-14 at 23 14 31

Nobody needs DOW or month name.

@fqueiruga
Copy link
Contributor Author

Does that short option take into account localization? For example day-month order differences between Europe and the US.

If I were to chose I would just put the date in ISO 8601 format but that would also be too long

@daniel-beck
Copy link
Member

Does that short option take into account localization? For example day-month order differences between Europe and the US.

Unsure what you mean. I demonstrate dd.mm.yy and m/d/yy. So it can be considered ambiguous in some locales, but it always matches the user's locale.

@daniel-beck
Copy link
Member

FWIW don't let my suggestion block this. Can always be applied later if deemed worthwhile.

@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 16, 2020
@timja
Copy link
Member

timja commented Apr 16, 2020

Let's merge tomorrow unless any objections.

@timja timja merged commit 4d5d030 into jenkinsci:master Apr 17, 2020
@fqueiruga fqueiruga deleted the compact-footer-timestamp branch April 29, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants