-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the timestamp on the footer more compact #4651
Conversation
Does the footer height remain the same after the change? |
It does, still 56px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine :) not tested manually.
WDYT of making
Nobody needs DOW or month name. |
Does that short option take into account localization? For example day-month order differences between Europe and the US. If I were to chose I would just put the date in ISO 8601 format but that would also be too long |
Unsure what you mean. I demonstrate dd.mm.yy and m/d/yy. So it can be considered ambiguous in some locales, but it always matches the user's locale. |
FWIW don't let my suggestion block this. Can always be applied later if deemed worthwhile. |
Let's merge tomorrow unless any objections. |
Small improvement to the footer timestamp. The font size is reduced to 12px and the label is shown on top of the timestamp:
Proposed changelog entries
N/A I'd say. The footer changes haven't been released on an LTS yet, and this is a really small one.
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@Wadeck
@oleg-nenashev
@timja
@daniel-beck
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate