Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-46669] Reword SetupWizard Continue as admin button #4676

Merged
merged 2 commits into from
Apr 25, 2020

Conversation

samhrncir
Copy link
Contributor

@samhrncir samhrncir commented Apr 20, 2020

See JENKINS-46669.

Proposed changelog entries

  • Entry 1: Reworded "Continue as admin" button of the plugin setup wizard.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@fqueiruga
@timja

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@fqueiruga
Copy link
Contributor

I don't see any reason to not approve it. @timja are you aware if there's a copyediting team that should review this?

@timja
Copy link
Member

timja commented Apr 21, 2020

I don't see any reason to not approve it. @timja are you aware if there's a copyediting team that should review this?

yes but it's only on jenkins-infra so can't tag them here

@samhrncir samhrncir changed the title Reworded SetupWizard Continue as admin button [JENKINS-46669] Reword SetupWizard Continue as admin button Apr 21, 2020
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+100, this button has been always confusing for me

Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but I think we need to do the same on translations.

@fqueiruga
Copy link
Contributor

Pinging @LinuxSuRen in case you want to revisit the cn translation.

@LinuxSuRen
Copy link
Member

@fqueiruga Thanks for reminding me. This is a good improvement.

@res0nance res0nance added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback labels Apr 24, 2020
@res0nance
Copy link
Contributor

Merging in 24h if no negative feedback

@res0nance res0nance merged commit 9e5d8d5 into jenkinsci:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants