-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-46669] Reword SetupWizard Continue as admin button #4676
Conversation
I don't see any reason to not approve it. @timja are you aware if there's a copyediting team that should review this? |
yes but it's only on jenkins-infra so can't tag them here |
core/src/main/resources/jenkins/install/pluginSetupWizard.properties
Outdated
Show resolved
Hide resolved
Co-Authored-By: Daniel Beck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+100, this button has been always confusing for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, but I think we need to do the same on translations.
Pinging @LinuxSuRen in case you want to revisit the cn translation. |
@fqueiruga Thanks for reminding me. This is a good improvement. |
Merging in 24h if no negative feedback |
See JENKINS-46669.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@fqueiruga
@timja
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).