Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine content and appearance of the project 'Configure' screen #9734

Merged
merged 25 commits into from
Oct 21, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Sep 16, 2024

This pull request updates the content and minor styling of the project 'Configure' screen to provide descriptions for each section, fix the sidebar for Pipeline projects, and decrease section padding a little. This is part of an ongoing effort to simplify Jenkins' many forms.

Changes

  • Sections now have descriptions to explain what they're for
  • Some section titles have been tweaked, dropping the 'Build' prefix. These are: 'Build Triggers' -> 'Triggers', 'Build Environment' -> 'Environment'. This has been done to help differentiate their labels at a glance.
  • Section description margins have been decreased
  • Pipeline sections now show in the sidebar

Before
image

After
image

Testing done

  • Form works as before

Proposed changelog entries

  • Refine content and appearance of the project 'Configure' screen

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

@janfaracik
Copy link
Contributor Author

/label web-ui,rfe

/reviewer @jenkinsci/sig-ux

@comment-ops-bot comment-ops-bot bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Sep 16, 2024
@comment-ops-bot comment-ops-bot bot requested a review from a team September 16, 2024 14:44
@daniel-beck

This comment was marked as outdated.

@janfaracik
Copy link
Contributor Author

Please add trailing periods to full sentences. Otherwise it'll be inconsistent or plain weird once a section has more than one sentence

Done :)

@daniel-beck daniel-beck added the security-approved @jenkinsci/core-security-review reviewed this PR for security issues label Sep 17, 2024
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 12, 2024
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 12, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - could you file a corresponding PR to pipeline please for consistency?

@timja timja requested a review from a team October 13, 2024 16:32
@timja
Copy link
Member

timja commented Oct 19, 2024

LGTM - could you file a corresponding PR to pipeline please for consistency?

@janfaracik ^^

@janfaracik
Copy link
Contributor Author

LGTM - could you file a corresponding PR to pipeline please for consistency?

@janfaracik ^^

Heya, I'm on it.

@timja
Copy link
Member

timja commented Oct 20, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 20, 2024
@timja timja merged commit 9af5950 into jenkinsci:master Oct 21, 2024
16 checks passed
@timja timja deleted the improve-project-settings branch October 21, 2024 18:35
@janfaracik janfaracik restored the improve-project-settings branch October 22, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants