-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine 'Administrative monitors' interface #9735
Refine 'Administrative monitors' interface #9735
Conversation
/label web-ui,rfe /reviewer @jenkinsci/sig-ux |
json: am.id) | ||
if (am.isSecurity()) { | ||
span(style: 'margin-left: 0.5rem', class: 'am-badge', _("Security")) | ||
div(style: "margin-bottom: 0.625rem") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to use one of the existing classes for spacing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're too large - smallest is 1rem. Might be an idea to have small spacing classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
Small PR to update the 'Administrative monitors' interface.
Before
After
What's changed
jenkins-badge
classTesting done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist