Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine 'Administrative monitors' interface #9735

Merged
merged 13 commits into from
Oct 2, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Sep 16, 2024

Small PR to update the 'Administrative monitors' interface.

Before
image

After
image

What's changed

  • Content simplified, dropped superfluous 'configuration' suffix, dropped repeated checkbox wrapper label
  • Now using the shared jenkins-badge class
  • Unused CSS removed (checked core and plugins, no usages)
  • Checkbox descriptions now work in the same way as the radio descriptions, previously there was an additional margin added

Testing done

  • Works as before

Proposed changelog entries

  • Refine 'Administrative monitors' interface.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

@janfaracik
Copy link
Contributor Author

/label web-ui,rfe

/reviewer @jenkinsci/sig-ux

@comment-ops-bot comment-ops-bot bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Sep 16, 2024
@comment-ops-bot comment-ops-bot bot requested a review from a team September 16, 2024 15:32
json: am.id)
if (am.isSecurity()) {
span(style: 'margin-left: 0.5rem', class: 'am-badge', _("Security"))
div(style: "margin-bottom: 0.625rem") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to use one of the existing classes for spacing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're too large - smallest is 1rem. Might be an idea to have small spacing classes.

@daniel-beck daniel-beck added the security-approved @jenkinsci/core-security-review reviewed this PR for security issues label Sep 16, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja requested a review from a team September 17, 2024 10:21
@timja
Copy link
Member

timja commented Sep 22, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 22, 2024
@MarkEWaite MarkEWaite merged commit 68ea077 into jenkinsci:master Oct 2, 2024
16 checks passed
@janfaracik janfaracik deleted the administrative-monitors branch October 2, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants