-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-73813] Show a notification when scheduling a build fails #9787
Conversation
When a build is triggered via the UI (either on the job page or via the buildbuttoncolumn in a view) and the crumb is no longer valid, there was still the tooltip shown that the build was scheduled, whereas nothing happened. This change will show a notification when scheduling failed.
I've chosen to use a notificationBar in case of an error as the hoverNotification doesn't allow to change color. |
I think it'd make sense to standardise on one, +1 on the notification. |
Co-authored-by: Jan Faracik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks :)
@@ -23,3 +23,4 @@ | |||
Task_scheduled={0} scheduled | |||
Schedule_a_task=Schedule a {1} for {0} | |||
Schedule_a_task_with_parameters=Schedule a {1} with parameters for {0} | |||
Task_schedule_failed=Failed to schedule build for {0}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task_schedule_failed=Failed to schedule build for {0}. | |
Task_schedule_failed=Failed to schedule build for {0} |
For consistency with the 'Build scheduled' content. Any thoughts?
Couple linting issues. |
This does not address the issue with Build Now from context menus (e.g., breadcrumb bar). Is that deliberate or just an oversight? |
ah yes, that I overlooked |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
When a build is triggered via the UI (either on the job page or via the buildbuttoncolumn in a view) and the crumb is no longer valid, the tooltip was shown that the build was scheduled, although nothing happened.
This change will show a notification when scheduling failed.
See JENKINS-73813.
Testing done
Manual testing
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist