[JENKINS-74795] Job created via REST API attaches to default view

[basil]

Problem

See JENKINS-74795. Creating jobs via the createItem REST API erroneously attaches those items to the default view after #9672.

Evaluation

In the working scenario prior to #9672, the Jenkins#doCreateItem method is invoked by Stapler via its routable interface method ModifiableItemGroup#doCreateItem. In the failing scenario after #9672, the (incorrect) ListView#doCreateItem method is invoked by Stapler via its routable superclass method View#doCreateItem. This (mostly) works by accident, since View#doCreateItem happens to delegate to Jenkins#doCreateItem, but the incorrect behavior is still apparent when the item is incorrectly added to the default view. View#doCreateItem should never be invoked in this scenario, and the only reason it is was a regression in routing in #9672.

Solution

Make the Jenkins#doCreateItem(StaplerRequest2, StaplerResponse2) default method routable, as the equivalent interface method was prior to #9672. For consistency with View#doCreateItem(StaplerRequest2, StaplerResponse2), add a @RequirePOST annotation as well. The deprecated compatibility methods remain non-routable as before.

Testing done

• Functional testing: new integration test passes before [JENKINS-73278] Migrate core from EE 8 to EE 9 #9672, fails after [JENKINS-73278] Migrate core from EE 8 to EE 9 #9672, and passes with this PR.
• Regression testing: CI build of Jenkins core, ATH, and BOM/PCT

Proposed changelog entries

• Do not add jobs created via the REST API to the default view.

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Closes #9933

[daniel-beck]

Compared Stapler traces of 2.474, 2.484, and PR build, for both Jenkins and Folder (legacy types without 2), and XML POST and copy mode, and this essentially restores the previous behavior. GET gets rejected as expected.

(Note to myself: RFE idea: Show parameter types in Stapler traces for web methods.)

[MarkEWaite]

I compared 2.474, 2.475, and the pre-release build from this pull request. The results from this build match the results from 2.474. I checked:

• Job created with createItem at root no longer assigns the job to the primary view
• Job created with createItem inside a view assigns the job to the view

Those behaviors are consistent between 2.474 and the build of this pull request. Thanks very much!

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge