Skip to content

Commit

Permalink
[maven-release-plugin] prepare release kubernetes-1.27.3
Browse files Browse the repository at this point in the history
  • Loading branch information
@Vlatombe
Vlatombe committed Oct 13, 2020
1 parent a3227ae commit 6813ac7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<groupId>org.csanchez.jenkins.plugins</groupId>
<artifactId>kubernetes</artifactId>
<version>${revision}${changelist}</version>
<version>1.27.3</version>
<name>Kubernetes plugin</name>
<description>Jenkins plugin to run dynamic agents in a Kubernetes cluster</description>
<packaging>hpi</packaging>
Expand All @@ -19,7 +19,7 @@
<connection>scm:git:https://github.com/jenkinsci/kubernetes-plugin.git</connection>
<developerConnection>scm:git:https://github.com/jenkinsci/kubernetes-plugin.git</developerConnection>
<url>https://github.com/jenkinsci/kubernetes-plugin</url>
<tag>${scmTag}</tag>
<tag>kubernetes-1.27.3</tag>
</scm>

<licenses>
Expand Down

2 comments on commit 6813ac7

@MihailKo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a last commit of the latest release and there is no option to create an issue in this project, i must express my frustration in the comment.
So nothing personal. Just hoping that it will reach someone.

What's up with "label" and "containerTemplate"?
If those are deprecated why are they still in a majority of examples?
What is the replacement for both?

Using "label" does not work properly any more. It breaks pod deployment with just redeploying a pod template from some previous build of any job that uses same label for the pod. How can I set a static prefix for the pod label now that it not the job name? It does not seem to be possible now.
With containerTemplate we ware able to set the version of the container. I can not find any alternative with using yamlFile for the template and overwriting some container parameters. If it was deprecated in favour of yaml parameter, how about making it work in combination with yamlFile first and than deprecating what was working?

@Vlatombe
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you use declarative since the warnings have been added there.

label has been deprecated for long. Omit it, and your pod templates will use a generated label instead, unique to your build.
There is a regression being handled for the problem you described.

About your use case requiring containerTemplate, do I understand right that you are providing some kind of template using yamlFile where you patch some fields (like image) using containerTemplate field?

Please sign in to comment.