Merge pull request #30 from jglick/SSHAuthenticator-logging

Failures in doAuthenticate should be printed to the supplied listener
jenkinsci · Sep 18, 2017 · 0f7f882 · 0f7f882
2 parents 026d3be + 0f6dd7f
commit 0f7f882
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/SSHAuthenticator.java b/src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/SSHAuthenticator.java
@@ -31,8 +31,8 @@
 import edu.umd.cs.findbugs.annotations.CheckForNull;
 import edu.umd.cs.findbugs.annotations.NonNull;
 import hudson.ExtensionList;
+import hudson.Functions;
 import hudson.model.BuildListener;
-import hudson.model.Hudson;
 import hudson.model.TaskListener;
 import hudson.remoting.Channel;
 import hudson.util.StreamTaskListener;
@@ -41,8 +41,6 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
-import java.util.logging.Level;
-import java.util.logging.Logger;
 import jenkins.model.Jenkins;
 import jenkins.security.SlaveToMasterCallable;
 import net.jcip.annotations.GuardedBy;
@@ -437,8 +435,7 @@ public final boolean authenticate() {
                 try {
                     authenticated = doAuthenticate();
                 } catch (Throwable t) {
-                    Logger.getLogger(getClass().getName())
-                            .log(Level.WARNING, "Uncaught exception escaped doAuthenticate method", t);
+                    listener.error("SSH authentication failed").println(Functions.printThrowable(t).trim()); // TODO 2.43+ use Functions.printStackTrace
                     authenticated = false;
                 }
             }