Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update baseline to 2.190.x #47

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Update baseline to 2.190.x #47

merged 1 commit into from
Sep 27, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Sep 27, 2019

For two reasons:

@jglick jglick requested review from jvz and kuisathaverat September 27, 2019 12:17
jglick
jglick commented Sep 27, 2019
View reviewed changes
pom.xml
<java.level>8</java.level>
<slf4jVersion>1.7.26</slf4jVersion> <!-- TODO pending https://github.com/jenkinsci/plugin-pom/pull/229 -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkinsci/plugin-pom#229

pom.xml
<java.level>8</java.level>
<slf4jVersion>1.7.26</slf4jVersion> <!-- TODO pending https://github.com/jenkinsci/plugin-pom/pull/229 -->
<!-- TODO use BOM after https://github.com/jenkinsci/bom/pull/110 -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkinsci/bom#110

@jglick jglick mentioned this pull request Sep 27, 2019
Merged
jvz
jvz approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MarkEWaite
Copy link
Contributor

I assume this means that the Jenkins plugin BOM for older versions (like bom-2.176.x:3) will remain with a version of the ssh-credentials plugin before this bump is released. Is my assumption correct?

@jglick
Copy link
Member Author

jglick commented Sep 27, 2019 •
edited
Loading

Correct. Technically, bom-2.190.x will receive 1.18.0, and then bom-2.176.x will override it to be the current 1.17.3 (or a subsequent 1.17.x, if we choose to backport some important fix).

@jvz jvz merged commit 7fbcd57 into jenkinsci:master Sep 27, 2019
@jglick jglick deleted the 2.190.x branch September 27, 2019 19:47
@jglick
Copy link
Member Author

jglick commented Oct 2, 2019

Can we get a release of this please? It is blocking jenkinsci/bom#110.

jglick added a commit to jglick/bom that referenced this pull request Oct 4, 2019
@jglick
No straightforward workaround for jenkinsci/ssh-credentials-plugin#47.
7114da5
@jvz
Copy link
Member

jvz commented Oct 7, 2019

@jglick just released 1.18 with this baseline.

@jglick jglick mentioned this pull request Oct 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@jvz jvz jvz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jglick @MarkEWaite @jvz @kuisathaverat