Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SemaphoreStep.waitForStart() for workflow to wait until semaphore release before continuing. #530

Closed
wants to merge 1 commit into from
Closed

Added SemaphoreStep.waitForStart() for workflow to wait until semaphore release before continuing. #530

wants to merge 1 commit into from

Conversation

cdgopal
Copy link
Contributor

@cdgopal cdgopal commented Apr 4, 2024

Added SemaphoreStep.waitForStart() for workflow to wait until semaphore release before continuing.

Description and fix: Previously, reliance on specific console messages for synchronization could lead to inconsistency and intermittent failures. By shifting to semaphore-based synchronization, the workflow ensures stability and predictability in execution.

Transitioning to SemaphoreStep.waitForStart() provides a more reliable synchronization approach, reducing flakiness risk linked to console message dependency.

Following is the error:

image image image

Testing done

Submitter checklist

…ntil the semaphore is released before continuing
@cdgopal cdgopal requested a review from a team as a code owner April 4, 2024 06:45
@cdgopal cdgopal changed the title [BEE-47634]-Added SemaphoreStep.waitForStart() for workflow to wait until semaphore release before continuing. Added SemaphoreStep.waitForStart() for workflow to wait until semaphore release before continuing. Apr 4, 2024
@cdgopal cdgopal closed this Apr 4, 2024
@cdgopal cdgopal deleted the BEE-47634-Improving-Jenkins-Workflow-Stability-with-Synchronization-Update branch April 4, 2024 09:58
@jglick
Copy link
Member

jglick commented Apr 4, 2024

@cdgopal this looks right to me and seems to complement jenkinsci/workflow-support-plugin#258; why was it closed?

@cdgopal
Copy link
Contributor Author

cdgopal commented Apr 4, 2024

@cdgopal this looks right to me and seems to complement jenkinsci/workflow-support-plugin#258; why was it closed?

@jglick This is public repo. As Raul suggested to create OSS ticket in jenkins Jira Jenkins - Jenkins Jira
for the affected plugin for the public repo but I am not familiar to create OSS ticket i.e. I closed this PR. Please suggest.

@cdgopal
Copy link
Contributor Author

cdgopal commented Apr 5, 2024

@jglick Please consider this PR "#531"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants