Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SemaphoreStep.waitForStart() for workflow to wait until semapho… #531

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Added SemaphoreStep.waitForStart() for workflow to wait until semapho… #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/java/com/cloudbees/jenkins/support/impl/NodeExecutorsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public void addContentsFiltered() throws Exception {
WorkflowRun workflowRun = Optional.ofNullable(p.scheduleBuild2(0))
.orElseThrow(AssertionFailedError::new)
.waitForStart();
j.waitForMessage("Running on", workflowRun);
SemaphoreStep.waitForStart("wait/1", workflowRun);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compare

support-core-plugin/src/test/java/com/cloudbees/jenkins/support/impl/NodeExecutorsTest.java

Line 172 in a457dfc

p.setDefinition(new CpsFlowDefinition("node('test') {semaphore 'wait'}", true));
and

support-core-plugin/src/test/java/com/cloudbees/jenkins/support/impl/NodeExecutorsTest.java

Line 197 in a457dfc

SemaphoreStep.success("wait/1", null);


ContentFilter filter = SupportPlugin.getDefaultContentFilter();

Expand Down
Loading