Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72561] Fix sidepanel.jelly not being loaded when build/project is not available (plug-ins, folders, etc.) #40

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

kinow
Copy link
Member

@kinow kinow commented Aug 10, 2024

Implements suggestion from Victor (https://issues.jenkins.io/browse/JENKINS-72561), to be more defensive on loading sidepanel.jelly.

Pending some manual tests to confirm everything is working fine after this change.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

…ct is not available (plug-ins, folders, etc.)
@kinow
Copy link
Member Author

kinow commented Aug 15, 2024

Tested manually, worked the same as before. Hoping this will fix the issue for users that found the sidepanel.jelly error.

@kinow kinow merged commit a85e687 into master Aug 15, 2024
14 checks passed
@kinow kinow self-assigned this Aug 15, 2024
@kinow kinow deleted the JENKINS-72561 branch August 15, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant