Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74247] extract inline JS script in TapStreamResult/body.jelly #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shlomomdahan
Copy link

JENKINS-74247

WHY
https://www.jenkins.io/doc/developer/security/csp/

Testing done

To find the view:

  1. create freestyle project and add execute shell step with the below:
cat > test.tap <<EOF
TAP version 13
1..3
ok 1 - Basic test execution
not ok 2 - Failed test case
  ---
  message: Test failed as expected
  severity: fail
  ...
ok 3 - Final test # SKIP Skipping for demo
EOF
  1. Add POST-Build Action: Publish TAP results and set the test Results input to : test.tap

BEFORE CHANGES:

Screen.Recording.2024-12-23.at.1.08.57.PM.mov

AFTER CHANGES:

Screen.Recording.2024-12-23.at.1.02.59.PM.mov

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • [] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shlomomdahan ! After the last release there were several reports for issues with parameters. I'm holding merging this until I have time to confirm the previous similar changes did not cause that issue.

Will merge it if it wasn't related to these JS changes, otherwise, will report what happened, revert and release a new version. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants