Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive on org.eclipse.jetty.alpn #1515

Closed
joan38 opened this issue Oct 4, 2018 · 7 comments
Closed

False positive on org.eclipse.jetty.alpn #1515

joan38 opened this issue Oct 4, 2018 · 7 comments

Comments

@joan38
Copy link

joan38 commented Oct 4, 2018

False positive on https://mvnrepository.com/artifact/org.eclipse.jetty.alpn/alpn-api

Identifiers

  • cpe: cpe:/a:jetty:jetty:1.1.3.v20160715 Confidence:Low suppress
  • maven: org.eclipse.jetty.alpn:alpn-api:1.1.3.v20160715 Confidence:Highest
  • cpe: cpe:/a:eclipse:jetty:1.1.3.v20160715 Confidence:Low

See comment from the author:
http4s/blaze#235 (comment)

Workaround suppression:

   <suppress>
       <notes>False-positive: it's about the implementation not the api</notes>
       <cve>CVE-2017-14798</cve>
       <cpe>cpe:/a:eclipse:jetty</cpe>
   </suppress>
@joan38
Copy link
Author

joan38 commented Oct 8, 2018

@jeremylong
I updated the workaround to something more specific.
Could you update the suppression? Because it's too much of a wildcard I think.

Thanks

@jeremylong
Copy link
Owner

@joan38 I actually don't think the suppression is too broad. It is very specific to the alpn-api which is not Jetty.

@joan38
Copy link
Author

joan38 commented Oct 20, 2018

@jeremylong but should we add at least the CVE?

@jeremylong
Copy link
Owner

Suppressing the CVE will suppress this single entry. Suppressing by CPE will prevent future CVEs from being reported against alpn-api - which will reduce the number of FP in the output. If someone is using alpn-api in addition to, for instance, embedded jetty - the embedded version of jetty would still get flagged.

@joan38
Copy link
Author

joan38 commented Oct 24, 2018

Great!
Should we close this now? Or we are waiting for the release?

@jeremylong
Copy link
Owner

jeremylong commented Oct 24, 2018 via email

@lock
Copy link

lock bot commented Nov 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants