Multiple proxy settings in maven settings breaks the plugin function. #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings. In case we find multiple settings for proxy in maven settings, pick the first found https one. Next pick http one. Only active proxies should be picked up. If there are no active proxies found, then simply fall back on existing state exception.
…ings. Since we are looping over the proxies, being consistent in picking proxy make more sense rather then picking only first one found. Also, it might be very much possible that proxy definition is specified in maven settings file but they are not active. Hence throwing IllegalStateException is not really correct?! Hence letting null return in case none of the proxy settings are active.
|
Tested the plugin with this in my settings.xml and things are working good. Can we please take this up for review? |
|
Can one of the admins verify this patch? |
|
Tested again with my latest changes. Working good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #831
Description of Change
In case we find multiple settings for proxy in maven settings, pick the first active one. Also, it might be very much possible that proxy definition is specified in maven settings file but they are not active. Hence throwing IllegalStateException is not really correct?! Hence letting null return in case none of the proxy settings are active.
Have test cases been added to cover the new functionality?
I would love to. But not able to figure out where are the relevant test cases for this at the moment. Hence I going ahead and raising this PR. Let us see if any test case fails for this.