Use pecoff4j to read dll/exe version information metadata on windows #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dll and exe on windows that are not .NET assembly are only analyzed by the filename. This is often not good enough because the filename can contain other numbers (x86, x64, ...) other than the version. To improve the situation I've reduced the confidence of the filename parsed version and created a new analyzer The FileVersionAnalyzer use the pecoff4j library to extract, if possible, the version from the file metadata
HEllRZA
reviewed
Jan 24, 2020
utils/src/main/java/org/owasp/dependencycheck/utils/Settings.java
Outdated
Show resolved
Hide resolved
|
About the testing, it would require to add a .dll or .exe file with some metadata to the repo. I could reuse a publicy available dll or forge a minimal one, Do you want me to add this to have this merged? |
jeremylong
added a commit
that referenced
this pull request
Jan 25, 2020
…ieving more than just the version number from the PE Headers
Merged
|
@pscamodio thank you for this PR! As you can see I've expanded on it with PR #2448. For the test case I just used one of the existing DLLs that is used in testing of the AssemblyAnalyzer. Let's move the conversation and any additional updates to the new PR. |
jeremylong
added a commit
that referenced
this pull request
Feb 1, 2020
* Use pecoff4j to read dll/exe version information metadata on windows Dll and exe on windows that are not .NET assembly are only analyzed by the filename. This is often not good enough because the filename can contain other numbers (x86, x64, ...) other than the version. To improve the situation I've reduced the confidence of the filename parsed version and created a new analyzer The FileVersionAnalyzer use the pecoff4j library to extract, if possible, the version from the file metadata * updated PR #2446 to move this to a more full fledged PE Analyzer retrieving more than just the version number from the PE Headers Co-authored-by: Amodio <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Dll and exe on windows that are not .NET assembly are only analyzed by the filename.
This is often not good enough because the filename can contain other numbers (x86, x64, ...) other than the version.
Description of Change
To improve the situation I've reduced the confidence of the filename parsed version and created a new analyzer
The FileVersionAnalyzer use the pecoff4j library to extract, if possible, the version from the file metadata
Have test cases been added to cover the new functionality?
no