Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work-around for MSHARED-998 until it's resolved and we can upgrade to a newer transfer-utils #3702

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

aikebah
Copy link
Collaborator

@aikebah aikebah commented Oct 6, 2021

Fixes Issue #3679

Description of Change

As a temporary work-around do not apply a filter to artifact-resolution when resolving for a DependencyNode that uses a <classifier> which would lead to a NullPointerException deep down in maven's internal logic.

Have test cases been added to cover the new functionality?

yes, an integration testcase has been added that triggers the error with the old codebase and succeeds with the workaround.

@boring-cyborg boring-cyborg bot added maven changes to the maven plugin tests test cases labels Oct 6, 2021
@aikebah aikebah requested a review from jeremylong October 6, 2021 17:04
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we would have to use both resolution mechanisms until the upstream bug is resolved. PR looks good - thanks!

@jeremylong jeremylong added this to the 6.4.0 milestone Oct 6, 2021
@jeremylong jeremylong merged commit 83f3deb into main Oct 6, 2021
@jeremylong
Copy link
Owner

I will try and release this on Friday morning - unfortunately, I can't release before then due to other time commitments (and the next release will also require some updates on the homebrew side)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maven changes to the maven plugin tests test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants