fix: upgrade to JCS3 #5114
Merged
fix: upgrade to JCS3 #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
ant
|
JCS 3.2 has been released 3 days ago. @jeremylong : Will the upgrade make it into 8.0.0 milestone? |
jeremylong
commented
Jan 12, 2023
|
3.2 does not appear to be in central yet (see failing build) |
|
My mistake. I was happy to see a stable version among tags. But as it looks a release should have a |
|
Asked about the release date here: https://issues.apache.org/jira/browse/JCS-233 |
|
@jeremylong JCS 3.2 was released in September. Would you prefer a rebase or a merge for this PR to bring it up-to-date? https://commons.apache.org/proper/commons-jcs/changes-report.html#a3.2 |
|
I just rebased this PR. I'll re-review what I did and likely merge this tomorrow (along with cutting the next release). |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to JCS3 to resolve cache misses in the gradle implementation. Additionally, this allows easier control over the JCS logging - as the logs are now routed to slf4j.
This is a draft PR as we must wait until JCS 3.2 is released due to a bug in the JCS logging.
Resolves #5096
Resolves dependency-check/dependency-check-gradle#293