fix(partial): Issue #5144 Avoid NPE on non-Include packageReference #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylong
approved these changes
Jan 13, 2023
aikebah
added a commit
that referenced
this pull request
Jan 20, 2023
Improved version of #5293. We should not attempt dereference of the null-valued attribute-node of an absent Include attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Prevents the NPE on non-Include package references by just ignoring them. A proper fix should actually do something with the package references, but due to a lack of documentation of the non-include options it's hard to tell what would have to be done with them. By ignoring the entry we at least allow DependencyCheck to complete successfully.
Have test cases been added to cover the new functionality?
no