fix: Improve thread safety issue #7338 #7366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnou
commented
Jan 30, 2025
| @@ -196,7 +196,9 @@ public void setDescription(String description) { | |||
| * @return the value of references | |||
| */ | |||
| public Set<Reference> getReferences() { | |||
| return references; | |||
| synchronized (references) { | |||
| return Collections.unmodifiableSet(new HashSet<>(references)); | |||
There was a problem hiding this comment.
lmk if you think unmodifiableSet is too heavy handed, but I think modifying anything through the getter is an anti-pattern and out-right dangerous, especially when there are already add methods.
johnou
changed the title
|
to avoid gc thrashing this approach makes more sense #7367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Improve thread safety to avoid possible issues with timsort.
Related issues
Have test cases been added to cover the new functionality?
no