Show background fetch status in bottom line #4215
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
|
I quite like the idea of just showing it every time, because often it causes a slight delay in some action I want to perform and it would be good to actually see the reason why. As for location, I'm fine with it at the bottom. It may be a little bit annoying for users who are hiding their bottom line (because it shows up again and slightly squashes the other panels when something is loading). We've got a separate issue for that here: #4189 |
|
Ok cool. Does that mean we can merge this as is (after rewording the commit message a bit)? Did you see the change in the first commit? I'm not entirely sure about it, see commit message for details. |
|
Yep, I think that's fine. LGTM |
As far as I can tell, this is not needed. The call to Refresh at the end of backgroundFetch takes care of redrawing after refreshing. The call was added in 2fc1498, that's a long time ago, and we had multiple big refactorings since then. Maybe it was needed back then but no longer is today.
This shows a status as if the user had typed 'f' manually in the files panel. I want this particularly for the first fetch after startup. There are often situations where I need to wait for this first background fetch to be done before I can do what I want (e.g. rebase my branch onto its base branch, or check out a branch that my coworker has told me they just pushed), but currently it's hard to tell when that is. For every subsequent background fetch after the first one it is less important, but it hopefully doesn't hurt, and it might be nice to have some visual indication that background activity is happening.
stefanhaller
force-pushed
the
show-background-fetch-status-in-bottom-line
branch
from
abfea47 to
5424785
Compare
stefanhaller
changed the title
- **PR Description** Fix occasional ugly flicker when showing the background fetch status (recently introduced with #4215). - **Please check if the PR fulfills these requirements** * [x] Cheatsheets are up-to-date (run `go generate ./...`) * [x] Code has been formatted (see [here](https://github.com/jesseduffield/lazygit/blob/master/CONTRIBUTING.md#code-formatting)) * [ ] Tests have been added/updated (see [here](https://github.com/jesseduffield/lazygit/blob/master/pkg/integration/README.md) for the integration test guide) * [ ] Text is internationalised (see [here](https://github.com/jesseduffield/lazygit/blob/master/CONTRIBUTING.md#internationalisation)) * [ ] If a new UserConfig entry was added, make sure it can be hot-reloaded (see [here](https://github.com/jesseduffield/lazygit/blob/master/docs/dev/Codebase_Guide.md#using-userconfig)) * [ ] Docs have been updated if necessary * [x] You've read through your own file changes for silly mistakes etc
This shows a status as if the user had typed 'f' manually in the files panel.
I want this particularly for the first fetch after startup. There are often
situations where I need to wait for this first background fetch to be done
before I can do what I want (e.g. rebase my branch onto its base branch, or
check out a branch that my coworker has told me they just pushed), but currently
it's hard to tell when that is.
For every subsequent background fetch after the first one it is less important,
but it hopefully doesn't hurt, and it might be nice to have some visual
indication that background activity is happening.