fix(no-if): report conditionals in call expressions

fixes #557
jest-community · Jul 26, 2020 · 4cfcf08 · 4cfcf08
1 parent 8670c39
commit 4cfcf08
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/rules/__tests__/no-if.test.ts b/src/rules/__tests__/no-if.test.ts
@@ -23,6 +23,18 @@ ruleTester.run('conditional expressions', rule, {
     },
   ],
   invalid: [
+    {
+      code: `it('foo', () => {
+        expect(bar ? foo : baz).toBe(boo);
+      })
+      `,
+      errors: [
+        {
+          data: { condition: 'conditional' },
+          messageId: 'conditionalInTest',
+        },
+      ],
+    },
     {
       code: `it('foo', () => {
         const foo = bar ? foo : baz;

diff --git a/src/rules/no-if.ts b/src/rules/no-if.ts
@@ -73,7 +73,9 @@ export default createRule({
 
     return {
       CallExpression(node) {
-        stack.push(isTestCase(node));
+        if (isTestCase(node)) {
+          stack.push(true);
+        }
       },
       FunctionExpression() {
         stack.push(false);