-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mock timers in example #12385
docs: mock timers in example #12385
Conversation
while running __tests__/infiniteTimerGame-test.js, i got following error: expect(received).toHaveBeenCalledTimes(expected) Matcher error: received value must be a mock or spy function Received has type: function Received has value: [Function setTimeout] 12 | // At this point in time, there should have been a single call to 13 | // setTimeout to schedule the end of the game in 1 second. > 14 | expect(setTimeout).toHaveBeenCalledTimes(1); | ^ 15 | expect(setTimeout).toHaveBeenLastCalledWith(expect.any(Function), 1000); so i added, jest.spyOn(global, 'setTimeout');
Hi @aditya04848! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! Can you update the other v27 docs as well (plus the one in docs/
)? This is a change in Jest v27 which uses modern timers 🙂
Codecov Report
@@ Coverage Diff @@
## main #12385 +/- ##
=======================================
Coverage 68.48% 68.48%
=======================================
Files 324 324
Lines 16969 16969
Branches 5061 5061
=======================================
Hits 11622 11622
Misses 5315 5315
Partials 32 32 Continue to review full report at Codecov.
|
@aditya04848 hey! I updated this, but in order to merge you need to sign the CLA. Could you do so? 🙂 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
while running tests/infiniteTimerGame-test.js, i got following error:
expect(received).toHaveBeenCalledTimes(expected)
so i added, jest.spyOn(global, 'setTimeout');
Summary
Test plan