-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document differences in coverage ignore comments between providers #12836
Conversation
Documents how to ignore lines for coverage statistics, and the differences between providers.
Hi @spenserblack! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
I found my changes in f14e29a to be overly wordy once I previewed, but I left the commit in there in case that level of detail is preferred after all. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Sounds good. Reads well next to Just thinking out loud, feel free to rework. What if ### `collectCoverage` \[boolean]
Default: `false`
Indicates whether the coverage information should be collected while executing the test. Because this retrofits all executed files with coverage collection statements, it may significantly slow down your tests.
+ Jest ships with two coverage providers: `babel` (default) and `v8`. See [`coverageProvider`](#coverageProvider) option for more details.
+
+ :::note
+
+ The `babel` and `v8` providers use `/* istanbul ignore next */` and `/* c8 ignore next */` comments to exclude lines from coverage reports, respectively. For more information, you can view the [`istanbuljs` documentation](https://github.com/istanbuljs/nyc#parsing-hints-ignoring-lines) and the [`c8` documentation](https://github.com/bcoe/c8#ignoring-uncovered-lines-functions-and-blocks).
+
+ :::
|
Yeah, it does look better there. Definitely easier to find, since that's probably where users will first look when setting up coverage. I'll move the comment and apply your suggestions. |
Co-authored-by: Tom Mrazauskas <[email protected]>
Moves from the note from under the `coverageProvider` section to under the `collectCoverage` section. Co-authored-by: Tom Mrazauskas <[email protected]>
Thanks! Looks good for my eye. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
It wasn't immediately clear how to ignore lines from the coverage report, and where to find the documentation on ignore comments.
This adds a note to the
coverageProvider
configuration option providing the basic ignore comments to ignore a line, and also permalinks to documentation for more complex ignore comment usage.Addresses #12835
Test plan
Only documentation was changed, so likely N/A 🤔