-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Yarn build error (ENONENT ERROR) #13204
Conversation
@@ -167,7 +167,7 @@ const excludedPackages = new Set(['@jest/globals']); | |||
let definitionFile = await fs.promises.readFile(filepath, 'utf8'); | |||
|
|||
rimraf.sync(path.resolve(packageDir, 'build/**/*.d.ts')); | |||
fs.rmSync(path.resolve(packageDir, 'dist/'), { | |||
fs.rmSync(path.resolve(packageDir, 'dist/**'), { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't seem right - rmSync
doesn't support globs, so it would just not do anything. It's some other read
that fails.
I'll try to dig up a windows computer and reproduce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the only windows machine I have access to is Windows 7, and the latest version of Node it's possible to install on it is v12 (which doesn't have fs.rm
API), so I'm unable to debug this 😅
@G-Rath you wouldn't have som spare time to at this, would you? 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can probably have a look tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet, thanks!
@Biki-das I'm not able to reproduce this locally using v16: Can you give more details on what versions you're on and what you're actually doing? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Whiled doing yarn build in the repo, I found this error , seems like it is specific to Windows
clearing the dist later fixed this issue as you can see below