Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using Node --inspect option in the docs on debugging #1998

Merged
merged 1 commit into from
Oct 26, 2016

Conversation

bent
Copy link
Contributor

@bent bent commented Oct 26, 2016

Summary

Stop using Node --inspect option in the docs on debugging

The technique described in the instructions does not pick up
breakpoints set with debugger statements. This issue is being
tracked by #1652, but
it's unclear how long it will take to resolve as it's actually
a Node issue.

As a work-around, have updated docs to describe connecting an
external debugger to the Node process.

Test plan

I have locally generated and previewed the updated documentation using the npm start command in the website directory.

The technique described in the instructions does not pick up
breakpoints set with `debugger` statements. This issue is being
tracked by jestjs#1652, but
it's unclear how long it will take to resolve as it's actually
a Node issue.

As a work-around, have updated docs to describe connecting an
external debugger to the Node process.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@cpojer cpojer merged commit 7166724 into jestjs:master Oct 26, 2016
@cpojer
Copy link
Member

cpojer commented Oct 26, 2016

thanks

@bent bent deleted the update-debug-instructions branch October 26, 2016 04:01
okonet pushed a commit to okonet/jest that referenced this pull request Nov 11, 2016
)

The technique described in the instructions does not pick up
breakpoints set with `debugger` statements. This issue is being
tracked by jestjs#1652, but
it's unclear how long it will take to resolve as it's actually
a Node issue.

As a work-around, have updated docs to describe connecting an
external debugger to the Node process.
nickpresta pushed a commit to nickpresta/jest that referenced this pull request Nov 15, 2016
)

The technique described in the instructions does not pick up
breakpoints set with `debugger` statements. This issue is being
tracked by jestjs#1652, but
it's unclear how long it will take to resolve as it's actually
a Node issue.

As a work-around, have updated docs to describe connecting an
external debugger to the Node process.
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
)

The technique described in the instructions does not pick up
breakpoints set with `debugger` statements. This issue is being
tracked by jestjs#1652, but
it's unclear how long it will take to resolve as it's actually
a Node issue.

As a work-around, have updated docs to describe connecting an
external debugger to the Node process.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants